Bug - Fixed New Area Unlocked can have unofficial location name

Veracity

Developer
Staff member
I recently made the "New Area Unlocked" messages linkify the image.This depends on KoLmafia being able to look up KoL's adventure name to figure out the snarfblat. Since we are in the process of changing unofficial names to official names, no problem.

I then noticed that the Trapper reveals two New Locations to you at once. I made our code linkify both.

Except, I just noticed today that we did not linkify the Lair of the Ninja SNowmen. Fortunately, I saved the page HTML.

Official KoL name - as seen in Last Adventure and the map of McLarge Huge and, we assume, the Florist Friar:
Lair of the Ninja Snowmen

KoLmafia's name:
Lair of the Ninja Snowmen

New Area Unlocked name:
The Lair of the Ninja Snowmen

HTML:
<table><tr><td valign=center><img src="http://images.kingdomofloathing.com/adventureimages/snowman.gif"></td><td valign=center class=small><b>The Lair of the Ninja Snowmen</b>, on <a href=place.php?whichplace=mclargehuge><b>Mt. McLargeHuge</b></a>.</td></tr></table>
The "linkify New Area Unlocked" code apparently needs to try munging the name - remove or add "The " - if looking up the name as specified doesn't match a location. What a kludge.

Nothing like consistency, KoL!
 

Crowther

Active member
The "linkify New Area Unlocked" code apparently needs to try munging the name - remove or add "The " - if looking up the name as specified doesn't match a location. What a kludge.

Nothing like consistency, KoL!
What the hell. KoL must be one ugly mess of code. Thanks for the extra effort making this work!
 
Top