Bug - Fixed Papier-Mache weapon combat radlibs causing faulty items to appear in session results

kdog

New member
For the past several months, I've been quietly waiting for someone else to bug report or fix this without my having to request. But here I am making a formal bug report.

When using a papier-mache weapon (such as the papier-mâchéte) in the main hand, hp/mp losses and gains appear in the session results as 'found items.' As an example, here is a combat log generated in version 15.8, r11818.

Code:
[5668] Hamburglaris Shield Generator
Encounter: mutated alielf
Strategy: C:\Users\Cygnus\KoLMafia\ccs\bca.ccs [default]
Round 0: Cygnus wins initiative!
New Version of BatBrain Available: 1.30
Upgrade from 1.29 to 1.30 here!

WHAM: Running SmartStasis
Round 1: Cygnus executes a macro!
Round 1: Cygnus uses the Rain-Doh indigo cup!
You gain 192 hit **sits**
Round 2: Cygnus casts SAUCY SALVE!
Unknown item found: You **coast** 10 **part** points
You **coast** 10 **part** points
WHAM: Starting evaluation and performing of attack
WHAM: Enqueuing a stun to help with the battle
Round 3: Cygnus executes a macro!
Round 3: Cygnus casts ENTANGLING NOODLES!
KoLmafia thinks it is round 4 but KoL thinks it is round 3
Round 4: Cygnus casts CANDYBLAST!
Round 5: Cygnus casts CANDYBLAST!
You acquire an item: Mr. Mediocrebar
Unknown item found: You **think** 37 **twiddle** points
You **think** 37 **twiddle** points
Round 6: Cygnus casts SPAGHETTI SPEAR!
You lose 35 **grade** points
Round 7: Cygnus casts SILENT SLICE!
Round 8: Cygnus casts SPAGHETTI SPEAR!
Unknown item found: You **build** 36 hit **contends**
You **build** 36 hit **contends**
Round 9: Cygnus casts SPAGHETTI SPEAR!
Round 10: Cygnus casts SPAGHETTI SPEAR!
You lose 33 hit **sums**
Round 11: Cygnus casts SPAGHETTI SPEAR!
Unknown item found: You **prevent** 33 **water** **travels**
You **prevent** 33 **water** **travels**
Round 12: Cygnus casts SPAGHETTI SPEAR!
You lose 33 hit points
Round 13: Cygnus casts SPAGHETTI SPEAR!
You lose 33 **heart** **cares**
Round 14: Cygnus casts SPAGHETTI SPEAR!
Round 15: Cygnus casts SPAGHETTI SPEAR!
Round 16: Cygnus wins the fight!
Your familiar gains a pound: Dairne, the 15 lb. Green Pixie
You acquire an item: lunar isotope
You acquire an item: lunar isotope
You acquire an item: lunar isotope
You acquire an item: elven medi-pack
You acquire an item: elven magi-pack
You gain 32 Beefiness
You gain 76 Magicalness
You gain 41 Chutzpah
 
Last edited:

kdog

New member
I'm not sure how throwing in wildcard support for two strings is too much text, but whatever you say.
 

Bale

Minion
It's not just two strings. First of all, mafia doesn't look for two strings since mafia has a lot of different sentences it uses to express damage. Instead mafia looks for the word damage, or a few alternatives that are used. When those key words are missing mafia has no idea what is going on. This would require a major reworking of the way mafia figures out damage dealt.
 
Last edited:

Catch-22

Active member
This would require a major reworking of the way mafia figures out damage dealt.

I've been working on and off on alternate methods of parsing combat text to support things like haiku, lolcat and anapests, I guess this would come under that umbrella too. It's pretty complicated stuff though, and I wouldn't submit a patch if it added unnecessary bloat to KoLmafia or adversely affected the parsing of regular combats. In other words, don't hold your breath :)
 

kdog

New member
I just felt like it should be less a matter of searching for damage and more how it /detects item drops./ But I see what you're saying. Thanks for the info.
 

Bale

Minion
Actually, looking at your output more closely I think mafia was getting even more confused by the stats you gained than the damage you were dealing.
 

Veracity

Developer
Staff member
Revision 12569 fixed this. At least, it no longer treats the rad libs as "unknown items".
 
Top