Page 5 of 5 FirstFirst ... 3 4 5
Results 41 to 49 of 49

Thread: Vhaeraun's Glorious PVP Bookkeeper

  1. #41
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,392

    Default

    There were three or four threads, all reporting the same bug. I responded on all of them that I'd fix it, but didn't bother reporting back on all of them that I HAD fixed it.
    Ph'nglui mglw'nafh Cthulhu
    R'lyeh wgah-nagl fhtagn.

  2. #42
    Senior Member
    Join Date
    Jun 2016
    Posts
    221

    Default

    The new ‡ indicator means it's failing to recognize the checking it twice mini (at least, I think that's the problem, it could of course be something completely unrelated).

  3. #43
    Senior Member
    Join Date
    Jun 2011
    Posts
    414

    Default

    It also looks like it's not seeing the Holiday Shopping mini. By which I mean that that mini is not showing in my results table at all.

  4. #44
    Senior Member
    Join Date
    Jun 2011
    Posts
    414

    Default

    Regarding the unrecognized Holiday Shopping mini, I'll be damned if I can figure out why this regex isn't matching this page text:
    Code:
    string informationBoothContests = "<td valign=\"top\" nowrap><b>(.*?)\\**</b></td><td valign=\"top\">(.*?)</td><td valign=\"top\" align=\"center\">(\\d+|\\?\\?)</td>";
    Code:
    <td valign="top" nowrap><b>Holiday Shopping*</b></td><td valign="top">You know what makes a great holiday gift?  Gargle Blasters! (Who has earned the most Pan-Dimensional Gargle Blasters?)</td><td valign="top" align="center" colspan="1">3</td>
    Regarding the recognized-but-not-tallied Checking It Twice mini, it was also my suspicion that the new double dagger (?) note icon is messing it up. I'm sure this could be solved by using &Dagger; (with a capital 'D') somewhere, to handle it. But I don't even entirely understand how the existing asterisk note icon is being handled, so I'm not sure where to make the change.

  5. #45
    Senior Member
    Join Date
    Apr 2009
    Posts
    1,810

    Default

    Regarding the unrecognized Holiday Shopping mini, I'll be damned if I can figure out why this regex isn't matching this page text:
    Originally Posted by PaladinWhite View Post
    regex has: align="center">
    page has: align="center" colspan="1">


    And the * is handled by: \\**
    (zero or more asterisks).

    So you probably want something like:
    Code:
     (\\*|&Dagger;)*
    (modulo correct quoting and grouping)
    Last edited by xKiv; 12-04-2017 at 03:55 PM.

  6. #46
    Senior Member
    Join Date
    Jun 2011
    Posts
    414

    Default

    Thanks a million, xKiv.

    I count myself among those sorry masses that are just capable enough with regex to get in trouble. Don't know how I missed that colspan attribute. I broadened the regex to match any attributes in that last <td> tag. Hopefully that broadening doesn't cause other issues.

    I'm still not entirely sure what's up with that double-backslash, double-asterisk to match the literal asterisk in mini names. Something-something-double-escaping? But even then, I don't get where the second asterisk comes in. My head hurts. At any rate, editing &Dagger; into that same regex solved the issue.

    All-in-all: a one-line change. Here's the updated version.
    Attached Files
    Last edited by PaladinWhite; 12-05-2017 at 07:24 PM. Reason: add attachment

  7. #47
    Senior Member
    Join Date
    Apr 2009
    Posts
    1,810

    Default

    I'm still not entirely sure what's up with that double-backslash, double-asterisk to match the literal asterisk in mini names. Something-something-double-escaping?
    Originally Posted by PaladinWhite View Post
    Yes. You need \\ in the source file to put a \ in the actual string value. And you need \* in the actual string value to match a literal asterisk.
    The second asterisk is just the normal greedy quantifier - match zero or more instances of the preceding "literal asterisk" (so it will match texts with no asterisk, with *, with **, with ***, etc...).

  8. #48
    Senior Member
    Join Date
    Jun 2011
    Posts
    414

    Default

    Has anyone recently seen the Bookkeeper tabulate results for more than 1,000 fites? The help text seems to indicate that it was handling (at least) up to 99,999 at one point. But my copy is capping at 1,000, no matter what I enter. (I've definitely fought more fites than that, and I've tabulated more than that in stints throughout the season, including after I deleted my cache file on the 6th.)
    Last edited by PaladinWhite; 12-20-2017 at 08:11 PM.

  9. #49

    Default

    Thanks a million, xKiv.

    I count myself among those sorry masses that are just capable enough with regex to get in trouble. Don't know how I missed that colspan attribute. I broadened the regex to match any attributes in that last <td> tag. Hopefully that broadening doesn't cause other issues.

    I'm still not entirely sure what's up with that double-backslash, double-asterisk to match the literal asterisk in mini names. Something-something-double-escaping? But even then, I don't get where the second asterisk comes in. My head hurts. At any rate, editing into that same regex solved the issue.

    All-in-all: a one-line change. Here's the updated version.
    Originally Posted by PaladinWhite View Post
    With the most recent season (but also before that) I ran into minis not being considered, notably Newest Born, Pirate Warrrs!, and Thirrrsty forrr Booze. So only 9 minis out of 12 were being tallied.

    So I took the vgpb.ash from PaladinWhite's post and replaced my original copy with it. That broke the script though: https://i.imgur.com/APXuqqN.jpg

Similar Threads

  1. 13119: Add Glorious Blessing of the War Snapper.
    By RSS Bot in forum Latest SVN Changes
    Replies: 0
    Last Post: 11-09-2013, 06:21 PM
  2. Bug - Fixed Can't cast Song of the Glorious Lunch in mafia interface in 10758
    By Theraze in forum Bug Reports
    Replies: 4
    Last Post: 03-10-2012, 06:38 PM
  3. Bug - Fixed Steel Lasagna is not affected by Got Milk/Gourmand/Glorious Lunch
    By GValko in forum Bug Reports
    Replies: 1
    Last Post: 02-29-2012, 06:00 AM
  4. 10652: Check for Glorious Lunch before eating in Axecore
    By RSS Bot in forum Latest SVN Changes
    Replies: 0
    Last Post: 02-27-2012, 02:51 PM
  5. Replies: 1
    Last Post: 02-21-2012, 11:56 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •