Page 3 of 4 FirstFirst 1 2 3 4 LastLast
Results 21 to 30 of 39

Thread: Enhanced Inventory Spoilers

  1. #21
    Senior Member
    Join Date
    Mar 2012
    Posts
    246

    Default

    Updated to 2.1.1! Introducing starred favorite items!

  2. #22
    Developer
    Join Date
    Apr 2006
    Posts
    884

    Default

    Is there a setting to disable the cli output? I don't really need to see the time spent running the script every time I hit an inventory page.
    Automatically download the newest daily build - Version 1.8
    Better Basement Automation
    - Version 1.??? Someone else is maintaining this
    Get an effect from a buffbot
    - Version 1.4

  3. #23
    Senior Member
    Join Date
    Oct 2011
    Posts
    233

    Default

    How did I ever live without this?!?

  4. #24
    Senior Member
    Join Date
    Mar 2012
    Posts
    246

    Default

    Is there a setting to disable the cli output? I don't really need to see the time spent running the script every time I hit an inventory page.
    Originally Posted by Rinn View Post
    I will add this in the next version

  5. #25
    Senior Member
    Join Date
    Apr 2012
    Posts
    131

    Default

    Neatness! And I found a bit of a typo; some items apparently give "Mystacility" stats from fights. I think you just need to change lines 111/112 in inventory_modifier_db to:

    Code:
    add_modifier_db_entry("Mysticality Experience", "+#_Mysticality_Stats_per_Fight", NUMERIC_MODIFIER_FLAG);
    add_modifier_db_entry("Mysticality Experience Percent", "+#%_Mysticality_Stats_per_Fight", NUMERIC_MODIFIER_FLAG);

  6. #26
    Senior Member ckb's Avatar
    Join Date
    Mar 2006
    Posts
    742

    Default

    There is a weird rendering issue with IE10, where it makes the questitem and safeitem test display funny. Because you use double <b> tags, they get shown as "extra bold" (and larger) and they look wrong. Changing these from <b> tags to <span> tags should fix the problem.

    Line 429:
    PHP Code:
            if (loadItem)
            {
                
    // hilight quest items
                
    if (!is_displayable(it))
                {
                    
    itemname "<span class=\"questitem\">" itemname "</span>";
                }
                else if (!(
    is_tradeable(it) && autosell_price(it) > 0))
                {
                    
    itemname "<span class=\"safeitem\">" itemname "</span>";
                } 

  7. #27
    Senior Member
    Join Date
    Mar 2012
    Posts
    246

    Default

    There is a weird rendering issue with IE10, where it makes the questitem and safeitem test display funny. Because you use double <b> tags, they get shown as "extra bold" (and larger) and they look wrong. Changing these from <b> tags to <span> tags should fix the problem.
    Originally Posted by ckb View Post
    Unfortunately, using <span> is not an option. KoL internally uses <span> tags to decrement item quantities when you use them in the inventory. If you use span tags anywhere else, that no longer works. That's why there's so much "abuse" of <b> and <small> tags. It's a clutzy hack, but one that is required for KoL. I'll see if I can find another workaround.

    In the meantime -- try your code and use an item that is a questitem or a safeitem, that you have more than one of. The name of the item will be replaced with (N-1) because KoL looks for the first span element inside the matching item class.

  8. #28
    Senior Member ckb's Avatar
    Join Date
    Mar 2006
    Posts
    742

    Default

    Unfortunately, using <span> is not an option. KoL internally uses <span> tags to decrement item quantities when you use them in the inventory. If you use span tags anywhere else, that no longer works. That's why there's so much "abuse" of <b> and <small> tags. It's a clutzy hack, but one that is required for KoL. I'll see if I can find another workaround.

    In the meantime -- try your code and use an item that is a questitem or a safeitem, that you have more than one of. The name of the item will be replaced with (N-1) because KoL looks for the first span element inside the matching item class.
    Originally Posted by rlbond86 View Post
    I see this now... and that is F-ed up. How about using the <mark> tag? Seems appropriate since you are highlighting the text anyway. the css takes care of the proper decoration.

  9. #29
    Senior Member
    Join Date
    Mar 2012
    Posts
    246

    Default

    I see this now... and that is F-ed up. How about using the <mark> tag? Seems appropriate since you are highlighting the text anyway. the css takes care of the proper decoration.
    Originally Posted by ckb View Post
    Yeah, you have no idea how long that took me to track down.

    I updated the CSS and it seems to work OK with <b> on IE10, can you check?

    Mark tag looks like it's not supported on old browsers, but I guess it's an option.

  10. #30
    Senior Member ckb's Avatar
    Join Date
    Mar 2006
    Posts
    742

    Default

    I updated the CSS and it seems to work OK with <b> on IE10, can you check?
    Mark tag looks like it's not supported on old browsers, but I guess it's an option.
    Originally Posted by rlbond86 View Post
    It works great with your new CSS. Thanks!

Similar Threads

  1. Replies: 0
    Last Post: 04-09-2015, 08:04 AM
  2. Bug - Fixed Spoilers for Fernswarthy's Basement
    By Ethelred in forum Bug Reports
    Replies: 8
    Last Post: 03-04-2015, 06:14 PM
  3. Feature - Implemented Spoilers for Twin Peak
    By Bale in forum Bug Reports
    Replies: 18
    Last Post: 03-23-2013, 09:46 AM
  4. Spoilers missing?
    By baethan in forum Community Support
    Replies: 4
    Last Post: 08-03-2012, 03:12 PM
  5. Replies: 15
    Last Post: 06-09-2011, 11:15 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •