Search results

Here is the two patches for making ctrl+tab work in chat: http://frikod.se/~capitol/0039-some-class-layout-restructuring-in-order-to-follow-t.patch http://frikod.se/~capitol/0040-making-crtl-tab-work-for-switching-tab.patch and github links...

Thats a good suggestion :) I'll add in ctrl-tab as forward one tab, and ctrl-shift-tab as backwards one tab.

And here is what i think is the last patch in this series of improvements: http://frikod.se/~capitol/0001-added-ctrl-number-as-a-shortcut-for-switching-tabs-i.patch It's also a usability patch, and it adds crtl+<number> as shortcuts to the tabs, so that you can more easily change tabs when you...

Here is another patch-set for improving the chat: http://frikod.se/~capitol/0035-got-the-chat-history-working-again-basic-functionall.patch http://frikod.se/~capitol/0036-guard-against-an-ArrayIndexOutOfBoundsException-that.patch...

The reason i included the final patch was that I suspected that final was added for speed reasons, since there was a number of private methods marked as final and thought it might be enlightening to bring the subject up for discussion. I'm working on some more usability improvements for the...

patch reworked: http://kolmafia.us/showthread.php?10540-Some-migrations-to-java-1-5

I posted a gigantic (and somewhat unusable) patch a couple of days ago with some java 1.5 upgrades, and got pretty good feedback on it. I have reworked the changes into one patch per type of change, so that it's easy to cherry-pick what you like and disregard what you don't. The patches...

Here is an improved patch that will apply with patch -p1 : http://frikod.se/~capitol/0003-improved-the-way-that-the-tabbed-chat-recieves-focus.patch The patch contains the unit test, as the test of the functionality belongs together with the implementation of the functionality and should be...

I'll try to produce svn compatible patches, will need to do some reading on the subject :) Regarding the size of the downloadable, it should stay the same, if you clean the build directory before you build the jar (if you have run the ant test target). The test target depends on the compilation...

thanks :)

broken up and submitted as two features: http://kolmafia.us/showthread.php?10522-infrastructure-to-support-unit-tests http://kolmafia.us/showthread.php?10523-improve-focus-handling-in-tabbed-chat

Hi I have now done some real development instead of just cosmetic changes to the code Here is a patch that improves the way that focus is handled on the tabbed chat, it moves focus to the input box every time that the window gains focus. This makes it possible to tab to the chat and start...

Hi In order to be able to write automatic unit and regression tests it's needed to have an ant target and some utility jar's. I'm also submitting another feature that contains a unittest, but I broke out the actual unit-test stuff into it's own patch. link to commit...

Sounds like a good idea to break the patch into two different ones, I'll do that and add them to the tracker. Regarding svn, it's such a horrible step backwards in functionality to start using svn instead of git, so I won't do that, but what i can do is to start using a git-svn clone of your...

Hi I have now done some real development instead of just cosmetic changes to the code ;) Here is a patch that improves the way that focus is handled on the tabbed chat, it moves focus to the input box every time that the window gains focus. This makes it possible to tab to the chat and start...

ok, i'll strip out all changes to imports :)

Good point about the style change, that's handled by my editor, but I'll make sure to fix it so that I don't break style. I also agree on the other points, didn't really think about the usecase when another block is added. Regarding the imports, yes, it's mostly just reordering and replacing...

Here is a patch with some changes: http://frikod.se/~capitol/StringBufferAndVariableBoxingCleanup.patch It's a bit to large to be really usable in my opinion, but there is also a commit history here: https://github.com/alexanderkjall/kolmafia/commits/master I split the commits to one commit...

Yeah, I totally agree on the fracturing of the codebase, I want to submit patches and get them accepted, that i choose git was just so that i could make local commits before I submit them as patches, it really helps when you don't have commit access yourself. Regarding speed, that only applied...

Yes, it was my checkout that had gotten corrupted somehow. The issue resolved itself when i deleted the checkout and instead made a clone of the repo over at github: https://github.com/mkszuba/kolmafia I have a vision of improving the user interface of the chat a bit, and i'll start working on...