Search results

We should just clear the error state via StaticEntity.setContinuationState() if we fall back to trying the replica deck (and succeed in doing so). (All of scripting, to a first approximation.)

r28729. My test script that runs print(modifier_eval("-23963")) now succeeds. (I then extended it to check all of the other numbers from -32768 to +32768.)

https://github.com/kolmafia/kolmafia/pull/3137

That seems fixable if we just avoid the small integer optimization for these special cases.

Note that you'll also want to setDepth() on any pulls or other operations that internally invoke git fetch. Are you referring to the preference `gitShowCommitMessages`? That only prints commits since the last fetch. And even then, if a repo had a thousand commits since the last fetch, we still...

I think https://github.com/kolmafia/kolmafia/pull/3091 should do the trick.

I had merged the other PR, and then noticed that it generated build failures on macOS. I sent https://github.com/kolmafia/kolmafia/pull/3034 to revert back to the broken state, but I'd also approve an appropriate fix-forward.

https://github.com/kolmafia/kolmafia/pull/3032 does the trick for me.

I suspect that's more of an oversight, in that it also works in the other direction: if I temporarily disable autoSatisfyWithCoinmasters, Mafia still uses coinmasters despite the preference saying not to. However, if I force refreshConcoctions() (as with `refresh concoctions`), that clears the...

That PR has been merged onto the main branch, but hasn't yet made it to the Release branch. Track https://github.com/loathers/TourGuide/pull/258 if you want to see when the fix will be available.

Well, I sent them https://github.com/loathers/TourGuide/pull/256 so we'll see when that gets merged.

@gausie asserts that this was being caused by Mafia code (possibly related to the daily deeds manager, if I had to guess?), and that this should be fixed by r28615.

That said, I also see an explicit reference in https://github.com/loathers/TourGuide/blob/main/Source/relay/TourGuide/Sets/Skills.ash#L209 which may be more relevant.

Hm, but the deprecation warning is configured in defaults.txt. I suppose it wouldn't be too bad if libram checked for the deprecated attribute and stopped populating that.

This is most likely coming from any one of the loathers scripts, due to https://github.com/loathers/libram/blob/main/src/propertyTypes.ts#L2 which in turn is autogenerated from all of the properties per the comment on line 1. I think the easiest workaround on our side is to remove it from...

FYI -- you'll have an easier time getting your change(s) accepted if you break up your PR into several smaller PRs so it's not as daunting to review all at once. (One PR per logical fix or perhaps per challenge path is a good rule of thumb. Bundling too many changes together makes it hard to...

If you're using `java` from the command line, you'll need to specify `java -jar Kolmafia-28594.jar`.

Hopefully you then reinstalled Java 21, since we require that at a minimum. fronobulax's suggestion to use multitool may also help.

appearance_rates has a two-parameter version. if you want stateful results, specify `true` as the second argument. This forces Mafia to call AreaCombatData.recalculate(), which in turn calls the code in adjustConditionalWeighting in the linked PR. Once recalculate() is called (one way or...

r28563