Bug - Fixed Trying to shore with nearly-out fortune cookie counter clears the counter
- Thread starter adeyke
- Start date
jasonharper
Developer
That is the intended behavior when a counter is going to expire 1 or 2 turns in the future; I assumed that users would be able to count to 1 or 2 on their own, and would find a reoccurrence of the counter warning in that short of a time to be more of an annoyance than a help.
However, this behavior could be easily changed. Comments, anyone?
However, this behavior could be easily changed. Comments, anyone?
Personally, I prefer being warned. It will only happen once or twice, so no big deal annoyance-wise. However, if I don't manage to count to 1 or 2 on my own, I feel very stupid. I prefer a slight annoyance to a not-so-slight facepalm.
(YMMV, no big deal either way, I will continue to use KoLmafia regardless.)
(YMMV, no big deal either way, I will continue to use KoLmafia regardless.)
StDoodle
Minion
I prefer being warned, as I've missed the actual number a good few times in my click-haste and ended up wasting a few turns in a SR zone to be "safe." Thing is, you're not likely to do something like shoring with a low SR counter unless you're in a hurry to get your turns in in the first place, so it seems even more likely, IMO, that a person in such a situation might miss the counter's number.
Bale
Minion
Change it. There is potential error and confusion the way it is now, but no downside to changing the behavior.
jasonharper
Developer
Ok, r8357 no longer deletes counters after notification if they expire in the future.
Note that this changes how you'd have to write a counterScript that actually handles future expirations: they should ONLY burn the indicated number of turns somewhere, nothing else. If they try to actually get the semi-rare (or whatever), they would trigger another instance of the script (that will get the semi-rare in response to the re-delivered counter expiration), resulting in a wasted turn.
Note that this changes how you'd have to write a counterScript that actually handles future expirations: they should ONLY burn the indicated number of turns somewhere, nothing else. If they try to actually get the semi-rare (or whatever), they would trigger another instance of the script (that will get the semi-rare in response to the re-delivered counter expiration), resulting in a wasted turn.
Bale
Minion
Thanks for the warning.